Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation of threat campaigns package #1085

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Add installation of threat campaigns package #1085

merged 1 commit into from
Aug 4, 2020

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Jul 31, 2020

Proposed changes

Threat campaigns is a highly accurate signature type that focuses on current known threat campaigns. It lives in a separate package and is controlled by enabling/disabling a violation see: https://docs.nginx.com/nginx-app-protect/configuration/#violations

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@rafwegv rafwegv added the enhancement Pull requests for new features/feature enhancements label Jul 31, 2020
@rafwegv rafwegv requested review from pleshakov and Rulox July 31, 2020 11:39
@rafwegv rafwegv self-assigned this Jul 31, 2020
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rafwegv rafwegv merged commit be4ad66 into master Aug 4, 2020
@rafwegv rafwegv deleted the ap-threatc branch August 4, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants