Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VirtualServer/VirtualServerRoute snippets support #1019

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add http-snippets field to VirtualServer to allow adding NGINX config snippets to the http context.
  • Add server-snippets field to VirtualServer to allow adding NGINX config snippets to the server context.
  • Add location-snippets field to VirtualServer and VirtualServerRoute to allow adding NGINX config snippets to the location context.
  • Add enableSnippets cli arg.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 1, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jul 1, 2020
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants