-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for App Protect module #1017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs-web/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
docs-web/configuration/global-configuration/command-line-arguments.md
Outdated
Show resolved
Hide resolved
Let's wait until #1009 is merged and make the changes here, I think is more fair/easier. EDIT: I'll follow up with Dean and coordinate who merges first, I don't want to delay this PR just because of the changes in Helm. |
Just an update: I merged as agreed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ability to use "external references" is also missing from the policy definition. Is that an intentional limitation?
c36ea8b
to
93c3678
Compare
I decided to add preserve unknown fields false to two fields, since they do not have a specific form (modifications) or are very complicated (signature sets). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafwegv 🚀
I think it was my merged PR that caused conflicts. sry! :)
Closing in favour of #1035 |
Proposed changes
Add App Protect integration to Ingress Controller.
This adds two crd's and changes in go code that enables watching on those resources.
policies and log configuration can be added to ingresses using annotations.
CR's are read and written onto container storage as files , referenced in nginx configurations.
Checklist
Before creating a PR, run through this checklist and mark each as complete.