Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Server selection dropdown in the Grafana Dashboard not working #2940

Closed
aknot242 opened this issue Aug 18, 2022 · 18 comments
Closed
Assignees
Labels
backlog candidate Pull requests/issues that are candidates to be backlog items good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities

Comments

@aknot242
Copy link
Contributor

Describe the bug
In the NGINX Plus Grafana dashboard that is contained in this repo, if you have multiple upstreams configured in NIC, changing the selected upstream appears to have no effect.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy NIC with Prometheus support
  2. Deploy a VirtualServer resource with multiple upstreams
  3. Install the dashboard and configure it per instructions in this repo
  4. Click the Upstream Server dropdown in the dashboard and click a specific upstream:

image

Expected behavior
The upstream-related graphs displayed in the dashboard should be filtered based on the selected dashboard.

Your environment

  • Version of the Ingress Controller - 2.3.0
  • Version of Kubernetes - 1.24
  • Kubernetes platform: k3s
  • Using NGINX Plus

Additional context

@github-actions
Copy link

Hi @aknot242 thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

@jasonwilliams14
Copy link
Contributor

@aknot242 Thanks for the feedback.

The grafana dashboard .json file that we provide in this repo is simple example to show users what type of metrics they can capture when using NGINX Ingress controller and grafana.

That said, feel free submit a PR to resolve the issue you are running into.
Thank you.

@aknot242
Copy link
Contributor Author

@jasonwilliams14 as you know, I frequently submit PRs if I feel like it is something I can confidently contribute. In this case, the fix is not immediately obvious to me, as I am not the author and it is a little outside of my realm of expertise. Do you know who the original author was? NGINX/F5, or was it contributed? I would be happy to collaborate with the original author or successor on a fix.

@hafe
Copy link
Contributor

hafe commented Aug 24, 2022

I have it fixed locally. Will try send a patch

@lucacome
Copy link
Member

thanks @hafe !

@hafe
Copy link
Contributor

hafe commented Aug 24, 2022

I found more, server_zone drop-down has no effect either

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Nov 23, 2022
@aknot242
Copy link
Contributor Author

Please keep this open.

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Nov 26, 2022
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 25, 2023
@aknot242
Copy link
Contributor Author

still broken, keep open. #rhymes

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Feb 26, 2023
@lucacome lucacome added the backlog candidate Pull requests/issues that are candidates to be backlog items label Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Jun 7, 2023
@aknot242
Copy link
Contributor Author

aknot242 commented Jun 7, 2023

Bumping to keep it open, especially now that it has the backlog candidate tag on it.

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Sep 7, 2023
@aknot242
Copy link
Contributor Author

aknot242 commented Sep 7, 2023

Bumping to keep it open once again, as it still has the backlog candidate tag on it.

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Sep 8, 2023
@brianehlert brianehlert added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Oct 20, 2023
@brianehlert
Copy link
Collaborator

There are current plans to expand the metrics available through the Prometheus exporter project to include the new /workers/ and /cache/ from the NGINX Plus API. Which continues to put this dashboard behind the times for easy, out of the box value.

We are happy to accept any contributions here. Even small ones.

@jasonwilliams14 jasonwilliams14 self-assigned this Oct 20, 2023
@hafe
Copy link
Contributor

hafe commented Oct 21, 2023

I have worked on a contribution. Hope to send it soon

@hafe
Copy link
Contributor

hafe commented Oct 21, 2023

I think there is a disconnect between server zone and upstream metrics. I assume that all upstreams belong to one and only one server zone. Pls correct me if I am wrong. Yet there are no server_zone label on upstream metrics. That would be nice for the dashboard. Is that a change in the exporter?

hafe added a commit to hafe/kubernetes-ingress that referenced this issue Oct 30, 2023
@aknot242
Copy link
Contributor Author

aknot242 commented Dec 5, 2023

Thank you, @hafe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog candidate Pull requests/issues that are candidates to be backlog items good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

5 participants