Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing whitespace in VirtualServer status message #2766

Closed
jsoref opened this issue Jun 16, 2022 · 1 comment · Fixed by #2767
Closed

Trailing whitespace in VirtualServer status message #2766

jsoref opened this issue Jun 16, 2022 · 1 comment · Fixed by #2767

Comments

@jsoref
Copy link
Contributor

jsoref commented Jun 16, 2022 

{
  "message": "Configuration for test/vs-test was added or updated ",
  "reason": "AddedOrUpdated",
  "state": "Valid"
}

https://github.com/nginxinc/kubernetes-ingress/blob/5355e6000c363e7fee1c4facaa813ada199fa361/internal/k8s/controller.go#L1666-L1687
@github-actions
Copy link

Hi @jsoref thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

@jsoref jsoref mentioned this issue Jun 17, 2022
Merged
6 tasks
@lucacome lucacome linked a pull request Jun 30, 2022 that will close this issue
Try to only include separators when necessary (#2766) #2767
Merged
6 tasks
jsoref added a commit to jsoref/kubernetes-ingress that referenced this issue Jun 30, 2022
@jsoref
Try to only include separators when necessary (nginx#2766)
a2dede6
ciarams87 added a commit that referenced this issue Jul 15, 2022
@jsoref @lucacome @ciarams87
Try to only include separators when necessary (#2766) (#2767)
0e7e34d 
Co-authored-by: Luca Comellini <[email protected]>
Co-authored-by: Ciara Stacke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to only include separators when necessary (#2766) jsoref/kubernetes-ingress
1 participant
@jsoref