[helm chart] enableSnippets should not depend from enableCustomResources

[AlessioCasco]

Hello!

Describe the bug
Within helm, controller.enableSnippets should not require to also have controller.enableCustomResources.
In our case we don't use CRDs at all, only ingress resources, so we should not need to enable them.

To Reproduce
Steps to reproduce the behavior:

1. set controller.enableSnippets: true into the values.yaml
2. helm install/upgrade
3. kubectl describe any ingress that uses annotations snippet and you will see the following error nginx-ingress-controller annotations.nginx.org/server-snippets: Forbidden: snippet specified but snippets feature is not enabled

Expected behavior
controller.enableSnippets should not depend from controller.enableCustomResources

Your environment

• Chart version: 0.11.3
• Version of the Ingress Controller : 2.0.3
• Version of Kubernetes: v1.20.12
• Using NGINX

If you agree with the above I can open a pr to move the parameter above line 146

Thanks
Alessio

[github-actions]

Hi @AlessioCasco thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

[AlessioCasco]

Adding some more info

We tried to enable the CDRs in order to be able to move forward with the upgrade but one cluster can't be upgraded because we think some CDRs were not installed when the ingress was first deployed since we always kept the parameter set to false:

E1125 10:33:32.628288       1 reflector.go:138] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:167: Failed to watch *v1.Policy: failed to list *v1.Policy: the server could not find the requested resource (get policies.k8s.nginx.org)