Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Michael Pleshakov <[email protected]>
ciarams87 and pleshakov committed Apr 8, 2022
1 parent 480df7b commit d883a06
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion deployments/helm-chart/README.md
Original file line number Diff line number Diff line change
@@ -182,7 +182,7 @@ Parameter | Description | Default
`controller.setAsDefaultIngress` | New Ingresses without an `"ingressClassName"` field specified will be assigned the class specified in `controller.ingressClass`. | false
`controller.watchNamespace` | Namespace to watch for Ingress resources. By default the Ingress controller watches all namespaces. | ""
`controller.enableCustomResources` | Enable the custom resources. | true
`controller.enablePreviewPolicies` | Enable preview policies. This field is deprecated. To enable OIDC Policies please use `controller.enableOIDC` instead. | false
`controller.enablePreviewPolicies` | Enable preview policies. This parameter is deprecated. To enable OIDC Policies please use `controller.enableOIDC` instead. | false
`controller.enableOIDC` | Enable OIDC policies. | false
`controller.enableTLSPassthrough` | Enable TLS Passthrough on port 443. Requires `controller.enableCustomResources`. | false
`controller.enableCertManager` | Enable x509 automated certificate management for VirtualServer resources using cert-manager (cert-manager.io). Requires `controller.enableCustomResources`. | false
2 changes: 1 addition & 1 deletion deployments/helm-chart/values.yaml
Original file line number Diff line number Diff line change
@@ -162,7 +162,7 @@ controller:
## Enable the custom resources.
enableCustomResources: true

## Enable preview policies. This field is deprecated. To enable OIDC Policies please use controller.enableOIDC instead.
## Enable preview policies. This parameter is deprecated. To enable OIDC Policies please use controller.enableOIDC instead.
enablePreviewPolicies: false

## Enable OIDC policies.
Original file line number Diff line number Diff line change
@@ -59,15 +59,15 @@ Default `true`.

### -enable-preview-policies

Enables preview policies. Deprecated in favor of [-enable-oidc](#cmdoption-enable-oidc).
Enables preview policies. This flag is deprecated. To enable OIDC Policies please[-enable-oidc](#cmdoption-enable-oidc) instead.

Default `false`.
&nbsp;
<a name="cmdoption-enable-oidc"></a>

### -enable-oidc

Enables OIDC policies. Requires [-enable-custom-resources](#cmdoption-enable-custom-resources)
Enables OIDC policies.

Default `false`.
&nbsp;
2 changes: 1 addition & 1 deletion docs/content/installation/installation-with-helm.md
Original file line number Diff line number Diff line change
@@ -185,7 +185,7 @@ The following tables lists the configurable parameters of the NGINX Ingress cont
|``controller.setAsDefaultIngress`` | New Ingresses without an ingressClassName field specified will be assigned the class specified in `controller.ingressClass`. | false |
|``controller.watchNamespace`` | Namespace to watch for Ingress resources. By default the Ingress controller watches all namespaces. | "" |
|``controller.enableCustomResources`` | Enable the custom resources. | true |
|``controller.enablePreviewPolicies`` | Enable preview policies. This field is deprecated. To enable OIDC Policies please use ``controller.enableOIDC`` instead. | false |
|``controller.enablePreviewPolicies`` | Enable preview policies. This parameter is deprecated. To enable OIDC Policies please use ``controller.enableOIDC`` instead. | false |
|``controller.enableOIDC`` | Enable OIDC policies. | false |
|``controller.enableTLSPassthrough`` | Enable TLS Passthrough on port 443. Requires ``controller.enableCustomResources``. | false |
|``controller.globalConfiguration.create`` | Creates the GlobalConfiguration custom resource. Requires ``controller.enableCustomResources``. | false |

0 comments on commit d883a06

Please sign in to comment.