Apply suggestions from code review

nginx · Jul 8, 2020 · 8dfc4dd · 8dfc4dd
1 parent b4bde8e
commit 8dfc4dd
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 20 deletions.
diff --git a/deployments/daemon-set/nginx-ingress.yaml b/deployments/daemon-set/nginx-ingress.yaml
@@ -31,11 +31,11 @@ spec:
          #containerPort: 9113
        #- name: readiness-port
          #containerPort: 8081
-        #readinessProbe:
-          #httpGet:
-            #path: /nginx-ready
-            #port: readiness-port
-          #periodSeconds: 1
+       #readinessProbe:
+         #httpGet:
+           #path: /nginx-ready
+           #port: readiness-port
+         #periodSeconds: 1
         securityContext:
           allowPrivilegeEscalation: true
           runAsUser: 101 #nginx

diff --git a/deployments/daemon-set/nginx-plus-ingress.yaml b/deployments/daemon-set/nginx-plus-ingress.yaml
@@ -31,11 +31,11 @@ spec:
          #containerPort: 9113
        #- name: readiness-port
          #containerPort: 8081
-        #readinessProbe:
-          #httpGet:
-            #path: /nginx-ready
-            #port: readiness-port
-          #periodSeconds: 1
+       #readinessProbe:
+         #httpGet:
+           #path: /nginx-ready
+           #port: readiness-port
+         #periodSeconds: 1
         securityContext:
           allowPrivilegeEscalation: true
           runAsUser: 101 #nginx

diff --git a/deployments/deployment/nginx-ingress.yaml b/deployments/deployment/nginx-ingress.yaml
@@ -30,11 +30,11 @@ spec:
          #containerPort: 9113
        #- name: readiness-port
          #containerPort: 8081
-        #readinessProbe:
-          #httpGet:
-            #path: /nginx-ready
-            #port: readiness-port
-          #periodSeconds: 1
+       #readinessProbe:
+         #httpGet:
+           #path: /nginx-ready
+           #port: readiness-port
+         #periodSeconds: 1
         securityContext:
           allowPrivilegeEscalation: true
           runAsUser: 101 #nginx

diff --git a/deployments/deployment/nginx-plus-ingress.yaml b/deployments/deployment/nginx-plus-ingress.yaml
@@ -30,11 +30,11 @@ spec:
          #containerPort: 9113
        #- name: readiness-port
          #containerPort: 8081
-        #readinessProbe:
-          #httpGet:
-            #path: /nginx-ready
-            #port: readiness-port
-          #periodSeconds: 1
+       #readinessProbe:
+         #httpGet:
+           #path: /nginx-ready
+           #port: readiness-port
+         #periodSeconds: 1
         securityContext:
           allowPrivilegeEscalation: true
           runAsUser: 101 #nginx

diff --git a/deployments/helm-chart/values.yaml b/deployments/helm-chart/values.yaml
@@ -259,6 +259,7 @@ controller:
 
   ## The PriorityClass of the ingress controller pods.
   priorityClassName:
+
   readyStatus:
     ## Enables readiness endpoint "/nginx-ready". The endpoint returns a success code when NGINX has loaded all the config after startup.
     enable: false

diff --git a/internal/k8s/task_queue.go b/internal/k8s/task_queue.go
@@ -65,6 +65,7 @@ func (tq *taskQueue) Requeue(task task, err error) {
 	tq.queue.Add(task)
 }
 
+// Len returns the length of the queue
 func (tq *taskQueue) Len() int {
 	glog.V(3).Infof("The queue has %v element(s)", tq.queue.Len())
 	return tq.queue.Len()