Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update link to 3rd party site #898

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Docs: Update link to 3rd party site #898

merged 5 commits into from
Oct 9, 2024

Conversation

nginx-aoife
Copy link
Contributor

Proposed changes

The link to the go-swagger install page is invalid. User gets a 404.
Updating link to point to https://goswagger.io/go-swagger/install/

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@nginx-aoife nginx-aoife requested a review from a team as a code owner October 9, 2024 13:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2024
dhurley
dhurley approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the README as well? https://github.com/nginx/agent?tab=readme-ov-file#launching-swagger-ui

nginx-seanmoloney
nginx-seanmoloney approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@nginx-seanmoloney nginx-seanmoloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nginx-aoife
Copy link
Contributor Author

@dhurley I updated the README too. Can you merge this as I don't have permissions.

@ADubhlaoich ADubhlaoich merged commit ea1465e into nginx:main Oct 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-seanmoloney nginx-seanmoloney nginx-seanmoloney approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell craigell approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@dhurley dhurley dhurley approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nginx-aoife @dhurley @ADubhlaoich @craigell @aphralG @nginx-seanmoloney