Add Labels to SwarmNode #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the vanilla image it is not supported to create DNS names of containers based on the swarm node labels. Lets imagine situation: we have container that exposes 2 ports: one of them is just working port (like 80), and the other is exporter port (for instance, 9811). Also we need to use swarm proxying only for 80 port but exporters must have unique dns names per machine without swarm load balancing. We just need to know where response come from. So this pull request resolves this use case. |
|
@jwilder can you review this PR? |
bugficks
added a commit
to bugficks/docker-gen
that referenced
this pull request
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.