docs: specify correct amount of volumes #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the middle of setting this up and was a bit confused by the README.md being a bit ambiguous about volume count. In some places it refers to there being three required volumes, but the subsequent example shows only two.
I found this commit 28bdc6b8 that removes the third volume and changes the language to refer to two volumes.
My conclusion is: there should be two volumes and there's been an editing mistake. This MR is just to fix the forgotten references to three volumes. I did NOT try to understand how anything works or WHY there is only two now.
((I don't think i've made an MR like this before. Should i have made an issue first?))