Adjust volume naming #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resmo
approved these changes
Nov 8, 2023
|
Looks good to me, the only issue I see is, this is going to be a breaking change for the ones already using the role. |
|
That is true. In that case, this could be a major release with a notice for existing users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to name volumes without the server hostname prefix. This PR removes it from the task. This way, it's still possible to add the hostname prefix manually, but also possible to omit it. On top of that, this change is inline with the README description, which implies that the prefix needs to be added manually. The volume example in vars file was changed to include the hostname prefix, just like in the README description.