Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Include ability to resize, attach, and detach volumes #14

Merged
merged 7 commits into from
Jan 22, 2021

Conversation

lalvarezguillen
Copy link
Contributor

@lalvarezguillen lalvarezguillen commented Jan 20, 2021

See this issue for context: #15

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a made a few improvements requests. let me know if you want to discuss anything

CHANGELOG.rst Outdated Show resolved Hide resolved
plugins/modules/vultr_block_storage.py Outdated Show resolved Hide resolved
plugins/modules/vultr_block_storage.py Outdated Show resolved Hide resolved
plugins/modules/vultr_block_storage.py Outdated Show resolved Hide resolved
plugins/modules/vultr_block_storage.py Outdated Show resolved Hide resolved
plugins/modules/vultr_block_storage.py Outdated Show resolved Hide resolved
@lalvarezguillen
Copy link
Contributor Author

Nice work, a made a few improvements requests. let me know if you want to discuss anything

Brilliant! Thanks a lot for the review.

I've tackled your observations. Please take another look when you get a chance

@resmo resmo merged commit dcb398f into ngine-io:master Jan 22, 2021
@lalvarezguillen lalvarezguillen deleted the develop branch February 13, 2021 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants