Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional supported_services in network offering #123

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

bilalstanz
Copy link
Contributor

@bilalstanz bilalstanz commented Jul 27, 2023

Adds additional supported_services to the allowed list in cs_network_offering,
tested NetworkACL service in cs 4.17

edit: attaching source link & screenshots

image

  • in cs ui there are 13 services
    Screenshot from 2023-07-28 13-43-20
    Screenshot from 2023-07-28 13-44-10
    Screenshot from 2023-07-28 13-44-16

@bilalstanz bilalstanz changed the title Adds more supported services in network offering Adds additional supported_services in network offering Jul 27, 2023
@resmo resmo self-requested a review July 27, 2023 16:24
@resmo
Copy link
Member

resmo commented Jul 27, 2023

could you please fix "ERROR: plugins/modules/cs_network_offering.py:158:161: E501: line too long (166 > 160 characters)" by creating a yaml list item per line, like so

    supported_services: 
      - Dns
      - PortForwarding
      - Dhcp
      - SourceNat
      - UserData
      - Firewall
      - StaticNat
      - Vpn
      - Lb
      - NetworkACL
      - SecurityGroup
      - Connectivity
      - BaremetalPxeService

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c4f5525) 83.75% compared to head (db98e78) 83.75%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files          56       56           
  Lines        5645     5645           
  Branches     1271     1271           
=======================================
  Hits         4728     4728           
  Misses        474      474           
  Partials      443      443           
Files Changed Coverage Δ
plugins/modules/cs_network_offering.py 88.17% <ø> (ø)
plugins/inventory/instance.py 78.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilalstanz
Copy link
Contributor Author

did it, thanks

@bilalstanz bilalstanz force-pushed the bilalstanz/more_supported_services branch from 90cdfeb to db98e78 Compare July 27, 2023 17:44
@resmo
Copy link
Member

resmo commented Jul 28, 2023

could you please provide a source where to find the list of supported services? or screenshot?

@bilalstanz
Copy link
Contributor Author

added source link and screenshot in op

@resmo resmo merged commit 34c4a67 into ngine-io:master Jul 28, 2023
@resmo
Copy link
Member

resmo commented Jul 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants