fix: single dash breaks yaml highlighting #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qvalentin
force-pushed
the
fix/single-dash-breaks-yaml-highlighting
branch
3 times, most recently
from
78f8cf4 to
f052365
Compare
baptman21
approved these changes
Oct 13, 2024
|
I have not yet written any parsers or grammars for tree sitter, so I'm not 100% qualified to look at this, but it looks good to me. |
qvalentin
force-pushed
the
fix/single-dash-breaks-yaml-highlighting
branch
from
305bd76 to
a99432a
Compare
|
Thanks, I just added a comment that if tree-sitter-grammars/tree-sitter-yaml#12 should get resolved, we can revert this. But until this happens I think this is a good enough solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very hacky fix for #23 that adds a new node type "yaml_no_injection_text" which will turn a single "-" between templates into a different node instead of text, so it will not be used for injections.
I would like to get some opinions @baptman21, @kmoschcau.
Effect in a large file:
