Usgs Astro CSM Code Changes #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some initial thoughts:
I'll probably have other comments, these are just my initial thoughts. |
|
Sweet, thank you for the initial review @sminster. We initially used 3.0.3.3 to create the USGSCSM set of camera so I wasn't sure if we would want the updates in 3.0.3 or main. I can rebase onto main and make some of the changes you have suggested |
I am a bit overly pedantic here, but ECEF is just a Cartesian system that rotates together with the planet. One may define a datum, or one may not, and even then, WGS84 is just one datum for Earth, while ECEF exists also for Mars, etc., and even bodies that are not approximately spherical.
* Added Windows cmake support and CI * git is weird * Properply starting conda
acpaquette
changed the title
3 tasks
|
@sminster I think I addressed most of your initial thoughts, and this PR should be ready for a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here are some changes from the USGS astro fork of the CSM. Most of these changes were made for CSM 3.0.3 but may be portable into the current version. The most notable are the CMake files and potentially the CI for appveyor and travis.
I just made the PR into the master area but I can update the PR as needed.
Adam Paquette