WGS84 Reference Frames Enhancement #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add WGS84ReferenceFrame.h and WGS84ReferenceFrame.cpp to satisfy GWG requirement "Reference frame Enhancements", Part 1 - WGS84 realization tracking. |
sminster
requested changes
Jan 20, 2022
Address Scott Minster comments
fix previous update which inserted header file code into .cpp file. This addresses Scott's comments to the .cpp file.
Address Scott's comments.
sminster
approved these changes
Feb 17, 2022
sminster
reviewed
Sep 15, 2022
| { | ||
| public: | ||
|
|
||
| struct CSM_EXPORT_API RealizationDefinition |
There was a problem hiding this comment.
I'm not sure that this inner struct provides much benefit. I think you should change WGSReferenceFrame to hold the two items (the string and float) and provides getter and setter methods for those. That would make this class simpler.
|
Before this PR can be merged, the branch needs to be updated to add the two new WGS84 files to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.