Fix problem for '[accept-user-input] = false' #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect character). (eg: write azerty. First time correctly deleted when losing focus but second time, when losing focus, don't delete first character 'a'. And it keeps going) Also avoid problem when part of value is replaced (eg: Chicago renamed Chicert become Chice)
almothafar
reviewed
Dec 18, 2018
.gitignore
Outdated
| @@ -3,7 +3,6 @@ typings | |||
| .idea | |||
| .vscode | |||
| *.log | |||
| dist | |||
There was a problem hiding this comment.
We don't need to commit build file and dist, so that's a totally wrong move when we do publish, the build should be done locally for who do publish, the only source code is needed, not the build itself.
added 2 commits
December 18, 2018 21:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem for '[accept-user-input] = false' (avoid keeping an incorrect character).
(eg: write azerty. First time correctly deleted when losing focus but second time, when losing focus, don't delete first character 'a'. And it keeps going)
Also avoid problem when part of value is replaced (eg: Chicago renamed Chicert become Chice)