WIP Support configurable client deadlines #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument will be used to manually configure the deadline for client timeout. It will be helpful for those RPCs that take longer than 5 seconds.
This is done automatically after compiling the project. However the only difference will be the edited arguments only.
This argument is measured in seconds, and then multiplied by 1000 to convert it to microseconds to pass it to the gpr_time_from_millis() function
This is done automatically after compiling the project. However, these are the main differences in this file after compiling the project.
Shehab7osny
changed the title
nfultz
changed the title
nfultz
reviewed
Apr 20, 2020
This will add client_deadline argument to the options() for client timeout options.
Here I removed the argument passed to the grpc_client function in order to avoid breaking the existing code. The argument will be set in options()
the options() function will set the parameter client_deadline for 10 seconds to test the timeout issues. I tested the code on this example and setting the client_deadline for 0 seconds will raise the exception '"gRPC c++ call timeout". While testing for any seconds greater than 0 worked perfectly!
After running the roxygen, Namespace was not altered and the Description file just updated the RoxygenNote to 7.1.0
Added the server-side streaming functionality in the server-side R code
|
Overall this is looking pretty good. A couple minor points on organization
Other todo's:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the following updates to solve the issue related to client-side deadline. I hope that these updates solve the problem. I tried my updated code on the example (Helloserver and Helloclient) and it worked perfectly. I think it will work on any other example too.