fix: explicitly add/delete constructors and assignment operators

nfrechette · Sep 19, 2023 · ce28378 · ce28378
1 parent a3150e4
commit ce28378
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/includes/rtm/impl/error.h b/includes/rtm/impl/error.h
@@ -115,6 +115,8 @@ RTM_IMPL_FILE_PRAGMA_PUSH
 
 		class runtime_assert final : public std::runtime_error
 		{
+			runtime_assert() = delete;					// Default constructor not needed
+
 			using std::runtime_error::runtime_error;	// Inherit constructors
 		};
 

diff --git a/includes/rtm/impl/matrix_cast.h b/includes/rtm/impl/matrix_cast.h
@@ -48,6 +48,10 @@ namespace rtm
 		struct matrix_caster<matrix3x3f>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix3x3f& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix3x3f&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{
@@ -88,6 +92,10 @@ namespace rtm
 		struct matrix_caster<matrix3x3d>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix3x3d& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix3x3d&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{
@@ -128,6 +136,10 @@ namespace rtm
 		struct matrix_caster<matrix3x4f>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix3x4f& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix3x4f&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{
@@ -170,6 +182,10 @@ namespace rtm
 		struct matrix_caster<matrix3x4d>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix3x4d& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix3x4d&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{
@@ -212,6 +228,10 @@ namespace rtm
 		struct matrix_caster<matrix4x4f>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix4x4f& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix4x4f&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{
@@ -250,6 +270,10 @@ namespace rtm
 		struct matrix_caster<matrix4x4d>
 		{
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(const matrix4x4d& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE constexpr explicit matrix_caster(matrix4x4d&& mtx_) RTM_NO_EXCEPT : mtx(mtx_) {}
+
+			matrix_caster(const matrix_caster&) = default;
+			matrix_caster& operator=(const matrix_caster&) = delete;
 
 			RTM_DISABLE_SECURITY_COOKIE_CHECK RTM_FORCE_INLINE RTM_SIMD_CALL operator matrix3x3f() const RTM_NO_EXCEPT
 			{