Unified Token Formatting and Rendering #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2021 19:06
- New toFormatted* token methods that accept options - New render() token method to return final HTML tag intermediate representation - New Options implementation to support token rendering = Removed Options#resolve() method in favour of render Still need to update the interfaces to take advantage of this new paradigm
nfrasser
force-pushed
the
unified-token-rendering
branch
from
7587c27 to
33f8657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for more cohesive formatting in Linkify's core methods, simpler interface implementations and consistent options across interfaces.
MultiToken#toFormatted*()methods that accept optionsMultiToken#render()method to return tag intermediate representation for final HTMLOptionsimplementation to support token renderingOptions#render()Fixes #357
Fixes #349