Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues list Lint broken on node v4 #18

Closed
nfischer opened this issue Dec 7, 2023 · 1 comment · Fixed by #19
Closed

Issues list Lint broken on node v4 #18

nfischer opened this issue Dec 7, 2023 · 1 comment · Fixed by #19
Labels

Comments

@nfischer
Copy link
Owner

nfischer commented Dec 7, 2023

Node version (or tell us if you're using electron or some other framework)

v4

ShellJS version (the most recent version/GitHub branch you see the bug on)

happening on GitHub Actions CI

Operating system

all

Description of the bug:

/home/runner/work/shelljs-plugin-sleep/shelljs-plugin-sleep/node_modules/eslint/node_modules/optionator/node_modules/word-wrap/index.js:9
  let lastCharPos = str.length - 1;
  ^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:[37](https://github.com/nfischer/shelljs-plugin-sleep/actions/runs/7125011126/job/19400187643?pr=17#step:5:38)3:25)
    at Object.Module._extensions..js (module.js:[41](https://github.com/nfischer/shelljs-plugin-sleep/actions/runs/7125011126/job/19400187643?pr=17#step:5:42)6:10)
    at Module.load (module.js:3[43](https://github.com/nfischer/shelljs-plugin-sleep/actions/runs/7125011126/job/19400187643?pr=17#step:5:44):32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/shelljs-plugin-sleep/shelljs-plugin-sleep/node_modules/eslint/node_modules/optionator/lib/help.js:6:14)
    at Object.<anonymous> (/home/runner/work/shelljs-plugin-sleep/shelljs-plugin-sleep/node_modules/eslint/node_modules/optionator/lib/help.js:260:4)

https://github.com/nfischer/shelljs-plugin-sleep/actions/runs/7125011126/job/19400187643?pr=17

It looks like one of our dependencies is no longer v4-compatible.

Example ShellJS command to reproduce the error:

npm run lint
@nfischer nfischer added the chore label Dec 7, 2023
nfischer added a commit that referenced this issue Dec 7, 2023
The lint command appears to be broken on node v4. It should be fine to
skip this on v4 though since we can run lint on >= v6.

Fixes #18
@nfischer nfischer changed the title chore: skip lint on node v4 Issues list Lint broken on node v4 Dec 7, 2023
@nfischer
Copy link
Owner Author

nfischer commented Dec 7, 2023

Looks like there's another bug on node v4. I filed issue #20 for this.

nfischer added a commit that referenced this issue Dec 7, 2023
The lint command appears to be broken on node v4. It should be fine to
skip this on v4 though since we can run lint on >= v6.

Fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant