Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment to annotation table #84

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add comment to annotation table #84

merged 2 commits into from
Jan 23, 2024

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Dec 21, 2023

Currently ambiguous regarding what the comment is attached to:

  1. NodeSpecific: Comment might describe the node to its left
  2. General: Comment always describes the process, regardless of its position

nfdi4plants/ARCtrl#261

@HLWeil HLWeil changed the base branch from main to v2.0.0 December 21, 2023 15:45
@HLWeil
Copy link
Member Author

HLWeil commented Jan 23, 2024

Decided on solution 2. Comments always refer to the annotation table.

@HLWeil HLWeil merged commit 574f5dc into v2.0.0 Jan 23, 2024
@HLWeil HLWeil mentioned this pull request Jun 6, 2024
Merged
@HLWeil HLWeil deleted the comment branch October 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HLWeil