Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON schema build #329

Merged
merged 25 commits into from
Mar 17, 2020
Merged

JSON schema build #329

merged 25 commits into from
Mar 17, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 17, 2020

New page to give interactive GUI for rearranging and building pipeline schema files.

Works in conjunction with nf-core schema build, see nf-core/tools#584

ewels added 25 commits March 12, 2020 18:40
@ewels
Start building the JSON Schema Builder tool
fd7b85a
@ewels
Start building UI for schema builder
2a5e8c8
@ewels
Code for finishing schema after edit and saving results
563a60d
@ewels
Schema builder: sort functionality
d2a9746
@ewels
Better input fields, validation for new default values
c5943a3
@ewels
Make required checkboxes work
36c3f12
@ewels
Schema builder: extra functionality
f699b33
@ewels
More parameter validation
edf6f41
@ewels
Schema builder: New option to add new params
71f6ed7
@ewels
Rename schema 'input' to 'params'
718dfd1
@ewels
Minor bugfixes
7010b05
@ewels
Better cursors for moving rows
0571802
@ewels
Minor css tweaks
175b0e7
@ewels
Built groups functionality
de30911
@ewels
Builder: Add delete functionality
50bec49
@ewels
Validate and set new defaults when changing param type
0d6869a
@ewels
Improve default value validationgs
3e5eb06
@ewels
Group label tweak
407a595
@ewels
Hidden flag, some more help text
6d5dd34
@ewels
Flags for hiding param and fontawesome icon
5455b97
@ewels
Make required arrays live in each object instead of just parent params
0b2d500
@ewels
Add keyboard shortcuts for navigating form
2072d7e
@ewels
New field for longer help text. Tweaks and refinements
d49e5a6
@ewels
Validate empty default fix. Clarify helptext formatting.
1ba9189
@ewels
Get rid of top-level params object
e2be2ee
@ewels ewels requested a review from a team March 17, 2020 11:06
@ewels ewels mentioned this pull request Mar 17, 2020
Merged
@ewels
Copy link
Member Author

ewels commented Mar 17, 2020

Quick gifs of how this works:

nf-core-schema-build

nf-score-schema-web

@drpatelh drpatelh merged commit d0d9617 into nf-core:master Mar 17, 2020
@ewels ewels deleted the json_schema_build branch March 17, 2020 11:40
@ewels
Copy link
Member Author

ewels commented Mar 17, 2020

What, you're not going to pick through 939 lines of custom JavaScript code?? 😆

@drpatelh
Copy link
Member

Oh, Im sorry, I misunderstood. Did you want to merge this before Xmas?

@apeltzer
Copy link
Member

Oh, Im sorry, I misunderstood. Did you want to merge this before Xmas?

Going to frame this and put it in my office :-D

@drpatelh drpatelh mentioned this pull request Mar 18, 2020
Merged
@ewels ewels mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewels @drpatelh @apeltzer