Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new command: nf-core logo-create to output an nf-core logo for a pipeline (instead of going through the website) #2662

Merged
merged 49 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
c962890
first version of nf-core logo command
mashehu Jan 16, 2024
f934535
first running version of logo creation function
mashehu Jan 16, 2024
2ad8824
remove debugging
mashehu Jan 16, 2024
e72fdfb
add type hints
mashehu Jan 16, 2024
911d46d
[automated] Update CHANGELOG.md
nf-core-bot Jan 16, 2024
9233dea
don't use removeprefix (requires python 3.9)
mashehu Jan 16, 2024
6a0ad74
Merge branch 'add-logo-creation' of github.com:mashehu/tools into add…
mashehu Jan 16, 2024
d441ef9
fix path to font file
mashehu Jan 16, 2024
2d6446b
fix path for assets
mashehu Jan 16, 2024
47f371a
bundle assets file
mashehu Jan 16, 2024
16a2b91
full path it is
mashehu Jan 16, 2024
bf9e93f
move manifest and use pkg_resources
mashehu Jan 16, 2024
7f1440b
switch to only generating png logos
mashehu Jan 17, 2024
ac79a37
fix command parameters
mashehu Jan 17, 2024
32f6da1
fix manifest file
mashehu Jan 17, 2024
6773a4c
address assets differently
mashehu Jan 17, 2024
76f39c7
add debugging
mashehu Jan 17, 2024
6d3677c
address the assets in a simpler way
mashehu Jan 17, 2024
ec5dcb4
cleanup assets folder
mashehu Jan 17, 2024
745396f
add debugging
mashehu Jan 17, 2024
0ce2091
fix path in manifest file
mashehu Jan 17, 2024
cc33ad9
fix jinja template for download_pipeline.yml action
mashehu Jan 17, 2024
244968b
debugging
mashehu Jan 17, 2024
c7e427f
add all files manually to manifest
mashehu Jan 17, 2024
4df7e2f
fix file name
mashehu Jan 17, 2024
352419a
fix logo output name
mashehu Jan 17, 2024
116e4de
fix tests
mashehu Jan 17, 2024
c290a98
run more verbosely
mashehu Jan 17, 2024
1edf9c9
more debugging comments
mashehu Jan 17, 2024
a0bde8c
fix logo file name
mashehu Jan 17, 2024
4364f57
allow some size fluctuation
mashehu Jan 17, 2024
cae7afa
use correct size factors
mashehu Jan 17, 2024
56e9758
increase test coverage
mashehu Jan 17, 2024
1007b6e
fix cli test
mashehu Jan 17, 2024
73099b8
wrap in raw comments to avoid jinja interference
mashehu Jan 17, 2024
fc741e2
include comments from code review
mashehu Jan 17, 2024
79adfa1
Update nf_core/__main__.py
mashehu Jan 17, 2024
2e44b48
Update tests/test_cli.py
mashehu Jan 17, 2024
f604f7d
add file name option
mashehu Jan 17, 2024
55330c4
Merge branch 'add-logo-creation' of github.com:mashehu/tools into add…
mashehu Jan 17, 2024
708994e
use correct name for logo creation
mashehu Jan 17, 2024
acf42d2
fix cli test
mashehu Jan 17, 2024
155cb3c
add filename test
mashehu Jan 17, 2024
4cc890a
add prefix to default name
mashehu Jan 17, 2024
70985fb
Merge branch 'dev' into add-logo-creation
mashehu Jan 18, 2024
a4c18e2
Apply suggestions from code review
mashehu Jan 18, 2024
259b5be
add svg output option
mashehu Jan 18, 2024
c843e88
oops, forgot some files
mashehu Jan 18, 2024
1fe7f05
Update test_cli.py
mashehu Jan 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:

# Run nf-core linting
- name: nf-core lint
run: nf-core --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned
run: nf-core --verbose --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned
working-directory: create-lint-wf

# Run the other nf-core commands
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- Fix Renovate Dockerfile updating issues ([#2648](https://github.com/nf-core/tools/pull/2648) and [#2651](https://github.com/nf-core/tools/pull/2651))
- Add new subcommand `nf-core tui`, which launches a TUI (terminal user interface) to intuitively explore the command line flags, built using [Trogon](https://github.com/Textualize/trogon) ([#2655](https://github.com/nf-core/tools/pull/2655))
- Update pre-commit hook astral-sh/ruff-pre-commit to v0.1.13 ([#2660](https://github.com/nf-core/tools/pull/2660))
- Add new subcommand: `nf-core logo-create` to output an nf-core logo for a pipeline (instead of going through the website) ([#2662](https://github.com/nf-core/tools/pull/2662))
- Update actions/cache action to v4 ([#2666](https://github.com/nf-core/tools/pull/2666))

# [v2.11.1 - Magnesium Dragon Patch](https://github.com/nf-core/tools/releases/tag/2.11) - [2023-12-20]
Expand Down
4 changes: 4 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ graft nf_core/pipeline-template
graft nf_core/subworkflow-template
include requirements.txt
include nf_core/.pre-commit-prettier-config.yaml
include nf_core/assets/logo/nf-core-repo-logo-base-lightbg.png
include nf_core/assets/logo/nf-core-repo-logo-base-darkbg.png
include nf_core/assets/logo/placeholder_logo.svg
include nf_core/assets/logo/MavenPro-Bold.ttf
Loading
Loading