Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix-linting workflows #1513

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Add fix-linting workflows #1513

merged 3 commits into from
Apr 13, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 13, 2022

Add ability to use @nf-core-bot fix linting within PR comments. Both for the main nf-core/tools repo and also in the template.

The nf-core/tools action also runs Black as well as Prettier.

Also updated the setup-python action to v3 from v1.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov

This comment was marked as off-topic.

@ewels
Copy link
Member Author

ewels commented Apr 13, 2022

@jfy133 said it was ok to self-merge, so blame him if this breaks everything 🤠 😆

@ewels ewels merged commit 3edd219 into nf-core:dev Apr 13, 2022
@ewels ewels deleted the nf-core-fix-linting branch April 13, 2022 10:23
@ewels
Copy link
Member Author

ewels commented Apr 13, 2022

Realised that this needs to be merged to the default branch before it runs, so we can't actually test it until the next release 😅

Ah well, it's a low priority feature. Not the end of the world if it doesn't work..

@mirpedrol mirpedrol mentioned this pull request May 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant