Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage info #1412

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Update usage info #1412

merged 2 commits into from
Feb 17, 2022

Conversation

mahesh-panchal
Copy link
Member

Updates suggestion for writing custom configuration.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that you don't have the latest version of yamllint.yml? Because the template linting errors were fixed in the latest version.

@mahesh-panchal
Copy link
Member Author

I don't know what's going on with the yaml linting there. I merged dev on my fork, opened up a Gitpod, made the change, and made the pull request.

@mashehu
Copy link
Contributor

mashehu commented Feb 16, 2022

yeah, yamllint inside the gitpod is fine... weird.

@mashehu
Copy link
Contributor

mashehu commented Feb 16, 2022

Oh, the yamllint we use inside github actions comes from npm and uses a different config file than the conda yamllint 🤦🏻 (especially, it has to be called yaml-lint.json). A simple fix would be to add a --ignore ./nf-core/template*/ to the command in the github workflow.

@mashehu mashehu mentioned this pull request Feb 16, 2022
@mahesh-panchal mahesh-panchal merged commit 8903ac1 into nf-core:dev Feb 17, 2022
@github-actions
Copy link
Contributor

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml") -c ./.yamllint.yml
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@mahesh-panchal mahesh-panchal deleted the update_template_usage branch July 14, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants