Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module linting for when condition #1397

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Add module linting for when condition #1397

merged 3 commits into from
Feb 4, 2022

Conversation

mahesh-panchal
Copy link
Member

@mahesh-panchal mahesh-panchal commented Feb 4, 2022 •
edited
Loading

Adds module linting for when condition

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov

This comment was marked as off-topic.

Sign in to view
@mahesh-panchal mahesh-panchal mentioned this pull request Feb 4, 2022
Closed
14 tasks
ewels
ewels approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pretty strict but as long as we're happy with that conceptually then the PR looks good 👍🏻

@mahesh-panchal mahesh-panchal merged commit 0ddcd23 into nf-core:dev Feb 4, 2022
@mahesh-panchal mahesh-panchal deleted the when_lint_check branch February 4, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahesh-panchal @ewels