Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nf-core launch for new schema #574

Closed
9 of 11 tasks
ewels opened this issue Mar 2, 2020 · 2 comments · Fixed by #626
Closed
9 of 11 tasks

Refactor nf-core launch for new schema #574

ewels opened this issue Mar 2, 2020 · 2 comments · Fixed by #626
Labels
command line tools Anything to do with the cli interfaces
Milestone

Comments

@ewels
Copy link
Member

ewels commented Mar 2, 2020

After discussion in nextflow-io/nextflow#866 we have decided not to use the JSON Schema hosted on the nf-core website. Instead, we will use the regular JSON Schema format for each pipeline.

The nf-core launch code needs updating to reflect this.

--

Started in #591

Still to do:

  • Fix (? for help) in booleans
  • Make -a flag do what it is supposed to do
  • Use defaults from nextflow config instead of schema? (warn if different from schema)
  • When pulling, get latest release or if no release then default branch.
  • Test with non-nf-core pipelines
  • Description and help text for groups
  • Check python tests
  • Check that importing a params file at launch time works
  • Grep main.nf (and other files?) for params.XX text that nextflow config has missed
  • Update documentation
  • Update changelog

Long term:

  • Link to the website for using a GUI to prepare parameters, instead of the CLI (if desired)
@ewels ewels added the command line tools Anything to do with the cli interfaces label Mar 2, 2020
@ewels ewels changed the title Refactor nf-core launch for new pipelines Refactor nf-core launch for new schema Mar 2, 2020
@ewels ewels added this to the 1.10 milestone Mar 25, 2020
@ewels
Copy link
Member Author

ewels commented Jun 23, 2020

A number of these things addressed in #626

@ewels ewels modified the milestones: 1.10, JSON Schema Jun 23, 2020
ewels added a commit to ewels/nf-core-tools that referenced this issue Jun 23, 2020
Always show description and help text for a group or parameter if we have it.

Fixes broken ? in booleans and missing group help text in nf-core#574
@ewels ewels linked a pull request Jun 23, 2020 that will close this issue
5 tasks
@ewels
Copy link
Member Author

ewels commented Jun 24, 2020

Ok, now all complete except for docs. See #626 for nearly a thousand lines of new awesomeness.

@ewels ewels closed this as completed Jun 24, 2020
@ewels ewels modified the milestones: JSON Schema, 1.10 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant