-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic restart & General csv file updates #562
Merged
FriederikeHanssen
merged 32 commits into
nf-core:dev
from
FriederikeHanssen:automatic_restart
Jun 9, 2022
Merged
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
aa12173
remove input from required options
FriederikeHanssen a35365c
allow optional input param again
FriederikeHanssen f235ea5
remove unuse no_strlka_bp
FriederikeHanssen 2c6001b
Weird failure on startup
FriederikeHanssen 7137435
move code to WorkflowSarek
FriederikeHanssen cffed55
Fix linting
FriederikeHanssen 2cd46c4
sremove input=null, to test on tower
FriederikeHanssen b23ea3f
Merge remote-tracking branch 'upstream/dev' into automatic_restart
FriederikeHanssen aa9c4be
Map.replace to replace values in params
FriederikeHanssen 358c9ee
add step mapping to restart
FriederikeHanssen 7e4e00a
some more docu in parallel
FriederikeHanssen 7b88e4d
use getName for filenames to make sure the right ones are always used
FriederikeHanssen c05ce62
currently overwritting if a vc produces multiple vcfs
FriederikeHanssen 1ca82dd
Use input vcf as output vcf name for annotation
FriederikeHanssen 182a1d0
all csv files stored in outdir/csv
FriederikeHanssen 9a7577f
only csv for complete cohort
FriederikeHanssen a9e85a4
If col.variantcaller availabl take that info
FriederikeHanssen 706ca5e
remove csv files that are not produced anymore
FriederikeHanssen 7c00b75
Fix brackets when using 'minus'
FriederikeHanssen 31dbc10
Fix variable name
FriederikeHanssen 259ab76
linting
FriederikeHanssen a257b0d
fix variable name
FriederikeHanssen d93259e
update usage for annotation csv
FriederikeHanssen 8345c69
use baseName to make file name to string and be able to use 'minus' p…
FriederikeHanssen 69270f7
remove unsused file from test
FriederikeHanssen 57999b6
simplify naming for tabix annotate
FriederikeHanssen 72f0711
naming is hard
FriederikeHanssen bb272e3
more naming
FriederikeHanssen 621cf1b
more test fixing
FriederikeHanssen 394101c
test for csv existence
FriederikeHanssen 605aed6
Update changelog
FriederikeHanssen a84b939
Merge upstream/dev
FriederikeHanssen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then why minus(".vcf") if basename here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here baseName removes .gz and then vcf is still left
Using
simpleName
would remove also anything after a dot in the regular filenameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will comment this better for future us