Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move most of local modules to nf-core modules #521

Merged
merged 28 commits into from
Apr 27, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse marked this pull request as draft April 14, 2022 13:03
@maxulysse maxulysse marked this pull request as ready for review April 25, 2022 20:15
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
subworkflows/nf-core/alignment_to_fastq.nf Outdated Show resolved Hide resolved
subworkflows/nf-core/alignment_to_fastq.nf Outdated Show resolved Hide resolved
subworkflows/nf-core/merge_index_bam.nf Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member Author

@mahesh-panchal @FriederikeHanssen fix issues that I had yesterday, actually no idea where they were coming, because couldn't reproduce this morning.
And manage to fix the condition to publish the file I wanted in the process I wanted.
Using the closure with saveAs did the trick, as it was not working with enabled

@maxulysse maxulysse merged commit 9c57179 into nf-core:dev Apr 27, 2022
@maxulysse maxulysse deleted the dev_modules_die_samtools_local_die branch April 27, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants