Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: prepare RC 3.3.2 #1262

Merged
merged 2 commits into from
Sep 29, 2023
Merged

FEAT: prepare RC 3.3.2 #1262

merged 2 commits into from
Sep 29, 2023

Conversation

maxulysse
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9aebc2d

+| ✅ 146 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.3.2
  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-29 12:41:09

FriederikeHanssen
FriederikeHanssen reviewed Sep 29, 2023
View reviewed changes
CHANGELOG.md
@@ -1221,7 +1223,7 @@ Initial release of `nf-core/sarek`, created with the [nf-core](http://nf-co.re/)

### Fixed

- [#665](https://github.com/SciLifeLab/Sarek/pull/665) - Input bam file now has always the same name (whether it is from a single fastq pair or multiple) in the `MarkDuplicates` process, so metrics too
- [#665](https://github.com/SciLifeLab/Sarek/pull/665) - Input bam file now has always the same spelling of name (whether it is from a single fastq pair or multiple) in the `MarkDuplicates` process, so metrics too
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this coming from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad copy paste over multiple lines

@FriederikeHanssen FriederikeHanssen merged commit b043eee into nf-core:dev Sep 29, 2023
@maxulysse maxulysse deleted the prepare-rc-3_3_2 branch February 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen