Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.10 #1254

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Important! Template update for nf-core/tools v2.10 #1254

merged 6 commits into from
Sep 26, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.10 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.10 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.10 release page.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 986ed6e

+| ✅ 147 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-26 08:40:41

SPPearce
SPPearce reviewed Sep 26, 2023
View reviewed changes
assets/multiqc_config.yml Show resolved Hide resolved
assets/multiqc_config.yml Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
lib/WorkflowSarek.groovy
@@ -52,7 +52,7 @@ class WorkflowSarek {

public static String toolCitationText(params) {

// TODO Optionally add in-text citation tools to this list.
// TODO nf-core: Optionally add in-text citation tools to this list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we actually do this?

@maxulysse maxulysse merged commit 96140de into dev Sep 26, 2023
@maxulysse maxulysse deleted the nf-core-template-merge-2.10 branch September 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@SPPearce SPPearce SPPearce approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nf-core-bot @maxulysse @FriederikeHanssen @SPPearce