Important! Template update for nf-core/tools v2.9 #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not fully up to date with the code, but looking good already |
|
asp8200
reviewed
Jul 4, 2023
asp8200
reviewed
Jul 4, 2023
asp8200
approved these changes
Jul 4, 2023
Yeah, this looks a lot like this guy is approving himself |
|
| <h4>References</h4> | ||
| <ul> | ||
| <li>Di Tommaso, P., Chatzou, M., Floden, E. W., Barja, P. P., Palumbo, E., & Notredame, C. (2017). Nextflow enables reproducible computational workflows. Nature Biotechnology, 35(4), 316-319. <a href="https://doi.org/10.1038/nbt.3820">https://doi.org/10.1038/nbt.3820</a></li> | ||
| <li>Ewels, P. A., Peltzer, A., Fillinger, S., Patel, H., Alneberg, J., Wilm, A., Garcia, M. U., Di Tommaso, P., & Nahnsen, S. (2020). The nf-core framework for community-curated bioinformatics pipelines. Nature Biotechnology, 38(3), 276-278. <a href="https://doi.org/10.1038/s41587-020-0439-x">https://doi.org/10.1038/s41587-020-0439-x</a></li> | ||
| <li>Di Tommaso, P., Chatzou, M., Floden, E. W., Barja, P. P., Palumbo, E., & Notredame, C. (2017). Nextflow enables reproducible computational workflows. Nature Biotechnology, 35(4), 316-319. doi: <a href="https://doi.org/10.1038/nbt.3820">10.1038/nbt.3820</a></li> |
There was a problem hiding this comment.
what about the sarek publication?
|
|
||
| public static String toolCitationText(params) { | ||
|
|
||
| // TODO Optionally add in-text citation tools to this list. |
There was a problem hiding this comment.
should we do this? Or is this so big we should add an issue for it for later?
There was a problem hiding this comment.
no, let's wait until we fix it with nf-core/tools#236
| @@ -883,12 +884,14 @@ | |||
| "type": "boolean", | |||
| "description": "Display help text.", | |||
| "fa_icon": "fas fa-question-circle", | |||
| "default": false, | |||
| "hidden": true | |||
| }, | |||
| "version": { | |||
There was a problem hiding this comment.
🤯 didn't even know we had this parameter 😆
FriederikeHanssen
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
2.9of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-2.9branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.
For more information about this release of nf-core/tools, please see the
v2.9release page.