Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_full.config to restore a static URI for megatests #1358

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Update test_full.config to restore a static URI for megatests #1358

merged 8 commits into from
Aug 21, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Aug 21, 2024 •
edited
Loading

Parameters containing variables are sanitised by Seqera Platform, where we run the megatests prior to release. Consequently the recent change to test_full will not work, and I propose going back to the static URI for now.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit eff73a9

+| ✅ 173 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-21 15:23:37

adamrtalbot
adamrtalbot reviewed Aug 21, 2024
View reviewed changes
conf/test_full.config Outdated Show resolved Hide resolved
@pinin4fjords pinin4fjords linked an issue Aug 21, 2024 that may be closed by this pull request
Test profiles broken for Platform #1344
Closed
@pinin4fjords pinin4fjords merged commit 4a01a63 into dev Aug 21, 2024
25 checks passed
@pinin4fjords pinin4fjords deleted the static_uri_megatests branch August 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test profiles broken for Platform
3 participants
@pinin4fjords @maxulysse @adamrtalbot