Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wipertools module (#7184) #7185

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

mazzalab
Copy link
Contributor

@mazzalab mazzalab commented Dec 9, 2024

New module

PR checklist

Closes #7184

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already - have some styling / convention remarks :)

modules/nf-core/wipertools/fastqgather/main.nf Outdated Show resolved Hide resolved
modules/nf-core/wipertools/fastqgather/main.nf Outdated Show resolved Hide resolved
modules/nf-core/wipertools/fastqgather/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/wipertools/fastqgather/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/wipertools/fastqgather/tests/base.config Outdated Show resolved Hide resolved
"""
input[0] = [
[ id:'test', single_end:true ],
file('https://raw.githubusercontent.com/nf-core/test-datasets/fastqrepair/testdata/truncated_clean.fastq', checkIfExists: true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update please

modules/nf-core/wipertools/reportgather/main.nf Outdated Show resolved Hide resolved
modules/nf-core/wipertools/reportgather/main.nf Outdated Show resolved Hide resolved
modules/nf-core/wipertools/reportgather/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/wipertools/reportgather/tests/main.nf.test Outdated Show resolved Hide resolved
@mazzalab mazzalab added WIP Work in progress and removed Ready for Review labels Dec 10, 2024
@mazzalab mazzalab requested a review from famosab December 10, 2024 16:13
@mazzalab mazzalab added Ready for Review and removed WIP Work in progress labels Dec 10, 2024
@mazzalab mazzalab self-assigned this Dec 10, 2024
@mazzalab mazzalab added WIP Work in progress and removed Ready for Review labels Dec 11, 2024
Comment on lines +17 to +29
setup {
run("WIPERTOOLS_FASTQSCATTER") {
script "../../fastqscatter/main.nf"
process {
"""
input[0] = [
[ id:'pp_' ], // meta map
file(params.modules_testdata_base_path + "genomics/sarscov2/illumina/fastq/test_1.fastq.gz", checkIfExists: true)
]
input[1] = 2 // number of splits
"""
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could move the setup block before the first test block (line 12) and reuse it in all tests.

Comment on lines +47 to +48
echo -e "@ERR001268.1 080821_HWI-EAS301_0002_30ALBAAXX:1:1:1090:1998/1" > ${out_folder}/${prefix}_1-of-2_suffix.fastq
echo -e "@ERR001268.2 080821_HWI-EAS301_0002_30ALBAAXX:1:1:1090:1998/2" > ${out_folder}/${prefix}_2-of-2_suffix.fastq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty files suffice here :)
but if you get the number of chunks you could also reuse them in the output (so create more files for more chunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: WIPERTOOLS
4 participants