Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: deeptrio #573

Closed
wants to merge 3 commits into from
Closed

Conversation

abhi18av
Copy link
Member

PR checklist

Closes #568

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@abhi18av abhi18av self-assigned this Jul 13, 2021
@abhi18av abhi18av added the new module Adding a new module label Jul 13, 2021
@grst grst closed this Jul 22, 2021
@grst grst reopened this Jul 22, 2021
@abhi18av
Copy link
Member Author

Hi @grst , aplogies because of lack of activity here.

I'm still waiting for the usage pattern to emerge on the sarek workflow based on nf-core/sarek#394, and as soon as I have more clarity, I'd finalize this and get this merged.

@grst
Copy link
Member

grst commented Jul 22, 2021 via email

@abhi18av
Copy link
Member Author

Ah, okay. Got it 👍

@grst
Copy link
Member

grst commented Jul 24, 2021

Getting your branch up-to-date with the latest master did the trick, the CI ran through finally.

@drpatelh drpatelh added Ready for Review WIP Work in progress and removed Ready for Review labels Nov 15, 2021
@JoseEspinosa
Copy link
Member

Hi @abhi18av, thank you for this PR! We are merging as many modules as possible now due to and impending restructuring of the entire repo. This will mean you will need to update the module to reflect these changes before it can be merged in the future. It appears like this module isn't ready to be merged so if applicable, we are converting it to draft and adding the WIP label. If this isn't the case please let us know and we will try to get the module in before the changes. Thanks again!

@matthdsm matthdsm added the stale Stale label Mar 6, 2023
@matthdsm
Copy link
Contributor

matthdsm commented Mar 6, 2023

Hi there!

We've noticed there hasn't been much activity here. Are you still planning on working on this?
If not, you can ignore this message and we'll close your PR in about 2 weeks

Cheers
the nf-core maintainers

@matthdsm matthdsm closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module stale Stale WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: deeptrio
5 participants