Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add makegraph2 #3843

Merged
merged 11 commits into from
Nov 28, 2023
Merged

add makegraph2 #3843

merged 11 commits into from
Nov 28, 2023

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Sep 15, 2023 •
edited
Loading

PR checklist

  • Add Makegraph2
  • Add manual version reporting for all controlfreec modules. New version 11.6b not reported when running -version, but still 11.6

@FriederikeHanssen
Copy link
Contributor Author

@nf-core-bot fix linting

@FriederikeHanssen
Copy link
Contributor Author

FriederikeHanssen commented Sep 16, 2023 •
edited
Loading

Unsure why the checksums on the pngs don't match, the images look the same to me:

Conda:
test_BAF_conda

Docker:
test_BAF_docker

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review September 16, 2023 16:44
@FriederikeHanssen FriederikeHanssen mentioned this pull request Sep 16, 2023
Closed
@maxulysse
Copy link
Member

either we merge with conda checksum failings or we remove checksum for the png

@edmundmiller edmundmiller requested a review from a team as a code owner October 19, 2023 16:26
@FriederikeHanssen
Copy link
Contributor Author

well I completely forgot about this PR and recreated it yesterday 🙈 can we just exclude conda?

@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Nov 28, 2023
@FriederikeHanssen FriederikeHanssen removed this pull request from the merge queue due to a manual request Nov 28, 2023
@FriederikeHanssen FriederikeHanssen added this pull request to the merge queue Nov 28, 2023
Merged via the queue into nf-core:master with commit a7bae48 Nov 28, 2023
@FriederikeHanssen FriederikeHanssen deleted the makegraph2 branch November 28, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@adamrtalbot adamrtalbot Awaiting requested review from adamrtalbot adamrtalbot was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @maxulysse @nf-core-bot