Add params.test_data_base and keep path coherent

[maxulysse]

PR checklist

Closes #XXX

• This comment contains a description of changes (with reason).
• If you've fixed a bug or added code that should be tested, add tests!
• If you've added a new tool - have you followed the module conventions in the contribution docs
• If necessary, include test data in your PR.
• Remove all TODO statements.
• Emit the versions.yml file.
• Follow the naming conventions.
• Follow the parameters requirements.
• Follow the input/output options guidelines.
• Add a resource label
• Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

[maxulysse]

cf nf-core/sarek#909

And https://github.com/nf-core/test-datasets/blob/sarek3/tests/config/test_data.config

[maxulysse]

Ran:

TMPDIR=~ PROFILE=docker pytest --tag cnvkit/batch --symlink --kwdof --git-aware --color=yes

Locally without issue

[edmundmiller]

Love it!

[FriederikeHanssen]

Sorry, I think I missed some major issues :/ . Why is this better then having the path in the header?

[maxulysse]

Sorry, I think I missed some major issues :/ . Why is this better then having the path in the header?

Just easier to modify.
Let's say you want to run the test locally.
Just download the files you need, and you just need to set the params.test_data_base and you're good to go

[matthdsm]

me likey!

[FriederikeHanssen]

Sorry, I think I missed some major issues :/ . Why is this better then having the path in the header?

Just easier to modify. Let's say you want to run the test locally. Just download the files you need, and you just need to set the params.test_data_base and you're good to go

alright, makes sense

[FriederikeHanssen]

looks good to me. Did you test with a local repo, that it all works as expected?

[maxulysse]

looks good to me. Did you test with a local repo, that it all works as expected?

Tested it locally, no issues.
Testing a similar things in nf-core/sarek#909, and no issues.

Actually solving 2 issues in one go there:

• params to modify the path whenever/wherever we (or anyone else) see fit.
• fixing the path, not to include data/, so that data/ is actually in the path of all files