Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: deepvariant #234

Closed
maxulysse opened this issue Feb 19, 2021 · 7 comments · Fixed by #572
Closed

new module: deepvariant #234

maxulysse opened this issue Feb 19, 2021 · 7 comments · Fixed by #572
Assignees
Labels
good first issue Good for newcomers new module Adding a new module
Milestone

Comments

@maxulysse
Copy link
Member

I think it would be good to have module for deepvariant

@maxulysse maxulysse added good first issue Good for newcomers new module Adding a new module labels Feb 19, 2021
@maxulysse maxulysse added this to the nf-core/sarek milestone Feb 19, 2021
@HediaTnani HediaTnani assigned HediaTnani and unassigned HediaTnani Mar 22, 2021
@abhi18av abhi18av self-assigned this Jul 2, 2021
@abhi18av
Copy link
Member

abhi18av commented Jul 6, 2021

Hi team,

I've started working on the development of the deepvariant module, however owing to the upcoming changes in the structure of nf-core/modules, I figured that it might be better to

  • work on the integration first as a local module in sarek Add dsl2 module for deepvariant sarek#394
  • once the modules repo is stable again, I'll port over the sarek-specific local deepvariant code to a module.

@projectoriented
Copy link
Contributor

Hello 👋!

How it's going? We're planning to use this module in our pipeline and was curious if there are any updates on this 😊 @ramprasadn

@abhi18av
Copy link
Member

abhi18av commented Aug 23, 2021

Hi @projectoriented ,

Actually, this module is a WIP as per nf-core/modules guidelines #572

I can prioritize the module this evening for you to hvae a look and circle back with feedback - would that be okay?

Update: If you're looking for a local module in the meantime, please refer https://github.com/nf-core/sarek/tree/dev/modules/local/deepvariant

@projectoriented
Copy link
Contributor

@abhi18av Thanks! I've added some comments, hope they help 😛

@FriederikeHanssen
Copy link
Contributor

@abhi18av can we close this?

@abhi18av
Copy link
Member

Sure @FriederikeHanssen 👍

@FriederikeHanssen
Copy link
Contributor

🤦‍♀️ mixed up sarek repo and modules repo earlier because I had both open. The module is not part of the nf-core modules yet as far as I see, so i will reopen . :D sorry about that

Lucpen pushed a commit to Clinical-Genomics/modules that referenced this issue Mar 23, 2022
Add/modify test data for assembly-related modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new module Adding a new module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants