Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing bin names for MultiQC BUSCO section #96

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Sep 2, 2020

The bin names for the BUSCO section within the MultiQC report were missing (#78).

When using input: file ('short_summary_*.txt') the files will be enumerated and the numbers interpreted as sample names by MultiQC. To keep the original filenames including the bin names, I changed this to file (short_summary).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@skrakau
Copy link
Member Author

skrakau commented Sep 7, 2020

Thanks @d4straub for reviewing!

@skrakau skrakau merged commit 7467788 into nf-core:dev Sep 7, 2020
@skrakau skrakau deleted the fix_multiqc_busco branch May 31, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants