-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging template updates and building schema #88
Conversation
…g-template-updates
05cd579
to
ddbec8d
Compare
ddbec8d
to
b52035c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, after the small corrections 👍
Ah wait, linting is failing, there are some markdown issues in |
And I think that |
…/mag into merging-template-updates
Yes, sorry, I missed that. Will update |
Although |
yes, that seems like a good solution, to add it but keep it hidden. I can understand that you did not want it there |
OK, I checked the template again, and it seems this parameter doesn't necessarily need to be in |
yes, that should be fine, it was created to use only in the test profile so read paths can be provided there. Don't forget to accept my suggestions though if you agree to them, as they solve a couple of bugs 😄 |
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Co-authored-by: Gisela Gabernet <[email protected]>
Thank you @ggabernet :) |
sure! 😄 |
Here are the updates for the new nf-core template as well as the changes needed for the new json
schema
.I changed the paths in
output.md
, since the sentence "All paths are relative to the top-level results directory." was added to the template.Currently there are no full size tests yet, thus the standard test profile is still specified in
.github/workflows/awsfulltest.yml
(created an issue for this #87).And I removed the pipeline specific parameters from the "usage.md", since this will be included with the json
schema
. Thehelp
message I didn't touch, since there were no changes in the template for this. I guess the functionality that this can be replaced with theschema
will come with future templates or DSL2.Let me know if I forgot something.
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md