Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output documentation #75

Merged
merged 14 commits into from
Jul 16, 2020
Merged

Improve output documentation #75

merged 14 commits into from
Jul 16, 2020

Conversation

d4straub
Copy link
Collaborator

Output documentation needed a review. Here it is.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@d4straub d4straub requested a review from skrakau July 14, 2020 15:27
@d4straub
Copy link
Collaborator Author

Since local linting and linting in my repo passes, I'll trigger it here once more.

@d4straub d4straub closed this Jul 15, 2020
@d4straub d4straub reopened this Jul 15, 2020
@skrakau skrakau changed the title Dev Improve output documentation Jul 15, 2020
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Here a few comments

docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
d4straub and others added 11 commits July 15, 2020 14:50
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@d4straub d4straub merged commit 1c400ba into nf-core:dev Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants