Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaBAT2 output docs #73

Merged
merged 3 commits into from
Jul 14, 2020
Merged

MetaBAT2 output docs #73

merged 3 commits into from
Jul 14, 2020

Conversation

d4straub
Copy link
Collaborator

Explanation of the MetaBAT2 output #60.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@d4straub d4straub requested a review from skrakau July 14, 2020 12:02
@d4straub d4straub linked an issue Jul 14, 2020 that may be closed by this pull request
Add documentation about MetaBAT2 output files #60
Closed
@d4straub
Copy link
Collaborator Author

Trigger new CI test, since the download of an external database failed.

@d4straub d4straub closed this Jul 14, 2020
@d4straub d4straub reopened this Jul 14, 2020
skrakau
skrakau approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output file naming conventions need to be adjusted for whole file, but can be done in separate PR. Everything else looks good to me.

@skrakau skrakau merged commit b377a82 into nf-core:dev Jul 14, 2020
@d4straub d4straub deleted the MetaBAT2-output-docs branch July 14, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation about MetaBAT2 output files
2 participants
@d4straub @skrakau