Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unnecessary MultiQC containers to nf-core/ubuntu:20.04 #651

Merged
merged 2 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#648](https://github.com/nf-core/mag/pull/648) - Fix sample ID/assembly ID check failure when no IDs match (reported by @zackhenny, fix by @prototaxites)
- [#646](https://github.com/nf-core/mag/pull/646) - GTDB-Tk directory input now creates a value channel so it runs for all entries to the process and not just the first (reported by @amizeranschi, fix by @prototaxites).
- [#639](https://github.com/nf-core/mag/pull/639) - Fix pipeline failure when a sample produces only a single bin (fix by @d-callan)
- [#652](https://github.com/nf-core/mag/pull/651) - Replace base container for bash only modules to reduce number of containers in pipeline (reported and fixed by @harper357)

### `Dependencies`

Expand Down
7 changes: 3 additions & 4 deletions modules/local/adjust_maxbin2_ext.nf
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ process ADJUST_MAXBIN2_EXT {
tag "${meta.assembler}-${meta.id}"
label 'process_low'

// Using container from multiqc since it'll be included anyway
conda "bioconda::multiqc=1.12"
conda "conda-forge::sed=4.7"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/multiqc:1.12--pyhdfd78af_0' :
'biocontainers/multiqc:1.12--pyhdfd78af_0' }"
'https://depot.galaxyproject.org/singularity/ubuntu:20.04' :
'nf-core/ubuntu:20.04' }"

input:
tuple val(meta), path(bins)
Expand Down
7 changes: 3 additions & 4 deletions modules/local/rename_postdastool.nf
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ process RENAME_POSTDASTOOL {
tag "${meta.assembler}-${meta.id}"
label 'process_low'

// Using container from multiqc since it'll be included anyway
conda "bioconda::multiqc=1.12"
conda "conda-forge::sed=4.7"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/multiqc:1.12--pyhdfd78af_0' :
'biocontainers/multiqc:1.12--pyhdfd78af_0' }"
'https://depot.galaxyproject.org/singularity/ubuntu:20.04' :
'nf-core/ubuntu:20.04' }"

input:
tuple val(meta), path(bins)
Expand Down
7 changes: 3 additions & 4 deletions modules/local/rename_predastool.nf
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ process RENAME_PREDASTOOL {
tag "${meta.assembler}-${meta.binner}-${meta.id}"
label 'process_low'

// Using container from multiqc since it'll be included anyway
conda "bioconda::multiqc=1.12"
conda "conda-forge::sed=4.7"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/multiqc:1.12--pyhdfd78af_0' :
'biocontainers/multiqc:1.12--pyhdfd78af_0' }"
'https://depot.galaxyproject.org/singularity/ubuntu:20.04' :
'nf-core/ubuntu:20.04' }"

input:
tuple val(meta), path(bins)
Expand Down
Loading