Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2.5.0 #524

Merged
merged 64 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
328740c
handle local kraken2 db
gregorysprenger Aug 31, 2023
7f8909b
handle local centrifuge db
gregorysprenger Aug 31, 2023
118271c
use busco_db and handle local and downloaded tar.gz files
gregorysprenger Sep 5, 2023
d4b6258
update information about kraken, centrifuge, and busco databases
gregorysprenger Sep 5, 2023
4304cf6
update parameter handling
gregorysprenger Sep 15, 2023
190129e
set busco_db input as a path channel
gregorysprenger Sep 15, 2023
1961247
handle busco_db inputs and allow for busco to auto download lineages
gregorysprenger Sep 15, 2023
b6d3e78
Template update for nf-core/tools version 2.10
nf-core-bot Sep 25, 2023
b2df8da
update changelog
jfy133 Sep 26, 2023
41ec8d7
Merge pull request #513 from nf-core/bump-version
jfy133 Sep 26, 2023
9b8ef78
Merge branch 'dev' into nf-core-template-merge-2.10
jfy133 Sep 26, 2023
58c4a38
[automated] Fix linting with Prettier
nf-core-bot Sep 26, 2023
e2952b0
fix dumpsoftwware hash
jfy133 Sep 26, 2023
91744ec
Comments after review
jfy133 Sep 26, 2023
bee4749
Improve TODO
jfy133 Sep 26, 2023
3f64e92
Update CHANGELOG
jfy133 Sep 26, 2023
0c7c31e
Fix CONCOCT missing in some globs
jfy133 Sep 26, 2023
42d70e6
Update CHANGELOG
jfy133 Sep 26, 2023
8dfb907
Fix directory names of GUNC output to prevent overwriting
jfy133 Sep 26, 2023
24fe29e
Apply suggestions from code review
jfy133 Sep 26, 2023
a2f6168
Update CHANGELOG
jfy133 Sep 26, 2023
5b4be5d
Update OUTPUT docs
jfy133 Sep 26, 2023
62b2d1c
Merge pull request #511 from nf-core/nf-core-template-merge-2.10
jfy133 Sep 26, 2023
3943efa
Merge branch 'dev' into fix-missing-concoct-globs
jfy133 Sep 27, 2023
f0b09f5
Merge branch 'dev' into fix-gunc-overwriting
jfy133 Sep 27, 2023
2db25be
Update docs/output.md
jfy133 Sep 27, 2023
e4860c4
Update megahit.nf
prototaxites Sep 27, 2023
f994012
Update CHANGELOG.md
prototaxites Sep 27, 2023
3cd0541
Merge pull request #514 from nf-core/fix-missing-concoct-globs
jfy133 Sep 27, 2023
f9691cf
Merge branch 'dev' into fix-gunc-overwriting
jfy133 Sep 27, 2023
4a8ca9a
Merge branch 'dev' into fix_megahit
prototaxites Sep 27, 2023
e8316ab
Merge pull request #515 from nf-core/fix-gunc-overwriting
jfy133 Sep 27, 2023
6ce28af
Merge branch 'dev' into fix_megahit
jfy133 Sep 27, 2023
fa9f1dc
Merge pull request #516 from prototaxites/fix_megahit
prototaxites Sep 27, 2023
4c064c0
update centrifuge_db help text
gregorysprenger Sep 28, 2023
9640d64
update kraken2_db help text
gregorysprenger Sep 28, 2023
d9e7cc8
update busco_db help text
gregorysprenger Sep 28, 2023
7f054c6
fix grammar error
gregorysprenger Sep 28, 2023
48f5bc1
Correct globs and put summary in right place for Tiara
jfy133 Oct 3, 2023
e550308
Update CHANGELOG.md
jfy133 Oct 3, 2023
90eb2cc
Update docs/output.md
jfy133 Oct 4, 2023
3c1e286
Apply suggestions from code review
jfy133 Oct 4, 2023
5ea7104
Merge pull request #520 from nf-core/tiara-publish-fix
jfy133 Oct 4, 2023
e09c6a0
space needed for when adding to p var
gregorysprenger Oct 5, 2023
1f5d1a7
fix busco directory handling and have consistency on channel vars
gregorysprenger Oct 5, 2023
42b914d
harshil rule on emit lines
gregorysprenger Oct 5, 2023
3521da0
db_name has to be the same as centrifuge filenames
gregorysprenger Oct 5, 2023
04ceb89
update changelog
gregorysprenger Oct 6, 2023
d511ebd
Fix `nulls` in bin depths
jfy133 Oct 6, 2023
5cb4f41
fix spelling error
gregorysprenger Oct 6, 2023
e4525bc
use file attribute getBaseName
gregorysprenger Oct 6, 2023
0d84819
revert back to only decompressing tar.gz files
gregorysprenger Oct 6, 2023
10ae039
handle centrifuge and kraken db parsing
gregorysprenger Oct 6, 2023
04e2b57
Merge pull request #522 from nf-core/fix-null-in-depths
jfy133 Oct 7, 2023
e77e44d
less verbose way of checking multiple file extensions
gregorysprenger Oct 8, 2023
21fcad2
remove view function from channel
gregorysprenger Oct 8, 2023
55fd640
use getSimpleName file attribute
gregorysprenger Oct 8, 2023
d122b49
update changelog
gregorysprenger Oct 8, 2023
a111ca8
Merge branch 'dev' into add_local_db
gregorysprenger Oct 9, 2023
f0e4ce6
Add depcrecateion and updated changed entries
jfy133 Oct 9, 2023
6190222
[automated] Fix linting with Prettier
nf-core-bot Oct 9, 2023
86ce3d7
Merge pull request #504 from gregorysprenger/add_local_db
jfy133 Oct 9, 2023
b3e5eec
Update version for release
jfy133 Oct 9, 2023
e219e7a
Update CHANGELOG.md [skip ci]
jfy133 Oct 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
Expand Down
4 changes: 3 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ Please use the pre-filled template to save time.
However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> If you need help using or modifying nf-core/mag then the best place to ask is on the nf-core Slack [#mag](https://nfcore.slack.com/channels/mag) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::info
If you need help using or modifying nf-core/mag then the best place to ask is on the nf-core Slack [#mag](https://nfcore.slack.com/channels/mag) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::

## Contribution workflow

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.11"
architecture: "x64"

- name: Install dependencies
Expand Down
68 changes: 68 additions & 0 deletions .github/workflows/release-announcments.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
name: release-announcements
# Automatic release toot and tweet anouncements
on:
release:
types: [published]
workflow_dispatch:

jobs:
toot:
runs-on: ubuntu-latest
steps:
- uses: rzr/fediverse-action@master
with:
access-token: ${{ secrets.MASTODON_ACCESS_TOKEN }}
host: "mstdn.science" # custom host if not "mastodon.social" (default)
# GitHub event payload
# https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
message: |
Pipeline release! ${{ github.repository }} v${{ github.event.release.tag_name }} - ${{ github.event.release.name }}!

Please see the changelog: ${{ github.event.release.html_url }}

send-tweet:
runs-on: ubuntu-latest

steps:
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Install dependencies
run: pip install tweepy==4.14.0
- name: Send tweet
shell: python
run: |
import os
import tweepy

client = tweepy.Client(
access_token=os.getenv("TWITTER_ACCESS_TOKEN"),
access_token_secret=os.getenv("TWITTER_ACCESS_TOKEN_SECRET"),
consumer_key=os.getenv("TWITTER_CONSUMER_KEY"),
consumer_secret=os.getenv("TWITTER_CONSUMER_SECRET"),
)
tweet = os.getenv("TWEET")
client.create_tweet(text=tweet)
env:
TWEET: |
Pipeline release! ${{ github.repository }} v${{ github.event.release.tag_name }} - ${{ github.event.release.name }}!

Please see the changelog: ${{ github.event.release.html_url }}
TWITTER_CONSUMER_KEY: ${{ secrets.TWITTER_CONSUMER_KEY }}
TWITTER_CONSUMER_SECRET: ${{ secrets.TWITTER_CONSUMER_SECRET }}
TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}

bsky-post:
runs-on: ubuntu-latest
steps:
- uses: zentered/[email protected]
with:
post: |
Pipeline release! ${{ github.repository }} v${{ github.event.release.tag_name }} - ${{ github.event.release.name }}!

Please see the changelog: ${{ github.event.release.html_url }}
env:
BSKY_IDENTIFIER: ${{ secrets.BSKY_IDENTIFIER }}
BSKY_PASSWORD: ${{ secrets.BSKY_PASSWORD }}
#
27 changes: 26 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,32 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 2.4.0 - 2023-09-25
## 2.5.0 - [2023-10-10]

### `Added`

- [#504](https://github.com/nf-core/mag/pull/504) - New parameters `--busco_db`, `--kraken2_db`, and `--centrifuge_db` now support directory input of a pre-uncompressed database archive directory (by @gregorysprenger).

### `Changed`

- [#511](https://github.com/nf-core/mag/pull/511) - Update to nf-core 2.10 `TEMPLATE` (by @jfy133)
- [#504](https://github.com/nf-core/mag/pull/504) - `--save_busco_reference` is now replaced by `--save_busco_db` (by @gregorysprenger).

### `Fixed`

- [#514](https://github.com/nf-core/mag/pull/514) - Fix missing CONCOCT files in downstream output (reported by @maxibor, fix by @jfy133)
- [#515](https://github.com/nf-core/mag/pull/515) - Fix overwriting of GUNC output directories when running with domain classification (reported by @maxibor, fix by @jfy133)
- [#516](https://github.com/nf-core/mag/pull/516) - Fix edge-case bug where MEGAHIT re-uses previous work directory on resume and fails (reported by @husensofteng, fix by @prototaxites)
- [#520](https://github.com/nf-core/mag/pull/520) - Fix missing Tiara output files (fix by @jfy133)
- [#522](https://github.com/nf-core/mag/pull/522) - Fix 'nulls' in depth plot PNG files (fix by @jfy133)

### `Dependencies`

### `Deprecated`

- [#504](https://github.com/nf-core/mag/pull/504) - `--busco_reference`, `--busco_download_path`, `--save_busco_reference` parameters have been deprecated and replaced with new parameters (by @gregorysprenger).

## 2.4.0 - 2023-09-26

### `Added`

Expand Down
2 changes: 1 addition & 1 deletion CITATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

- [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/)

> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. Available online https://www.bioinformatics.babraham.ac.uk/projects/fastqc/.
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].

- [Filtlong](https://github.com/rrwick/Filtlong)

Expand Down
Loading