Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to save assembly-mapped reads #494

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add ability to save assembly-mapped reads #494

merged 2 commits into from
Aug 16, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Aug 16, 2023

closes #487

(breaking my own rule, but very simple change while we are waiting for final CAT bugfix)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 changed the base branch from master to dev August 16, 2023 15:51
@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/nf-core-mag master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/nf-core-mag dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6bdbad0

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-16 15:55:09

prototaxites
prototaxites reviewed Aug 16, 2023
View reviewed changes
conf/modules.config
pattern: "*.log"
],
[
path: { "${params.outdir}/Assembly/${assembly_meta.assembler}/QC/${assembly_meta.id}" },
Copy link
Contributor

@prototaxites prototaxites Aug 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Assembly/${assembly_meta.assembler}/(bams|maps)/${assembly_meta.id} or similar? Or even AssemblyMaps/${assembly_meta.assembler}/${assembly_meta.id}/? Not sure that bams/bais fit into the context of 'QC'!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think QC would be okay because the alignment can be used to quality check the assemblies, but agree that keeping it broader (like bam/maps) might work better because these BAM files have other uses as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, I'm keeping them alongside where the bowtie2 log file is saved... I don't want to rock the boat too much v😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree we can reconfigure the output in the future, then could you give a ✅!

@jfy133
Copy link
Member Author

jfy133 commented Aug 16, 2023

Thanks @CarsonJM (and @prototaxites !)

@jfy133 jfy133 merged commit 2090c56 into nf-core:dev Aug 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prototaxites prototaxites prototaxites left review comments

@CarsonJM CarsonJM CarsonJM approved these changes

@d4straub d4straub Awaiting requested review from d4straub

@alexhbnr alexhbnr Awaiting requested review from alexhbnr

@maxibor maxibor Awaiting requested review from maxibor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to export BAM file with reads aligned against the contigs to results folder
3 participants
@jfy133 @prototaxites @CarsonJM