Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BUSCO bash code a script #444

Merged
merged 7 commits into from
May 25, 2023
Merged

Move BUSCO bash code a script #444

merged 7 commits into from
May 25, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented May 16, 2023

I just couldn't cope anymore with trying to debug pipelines during tests and having 100xs of a 300 line error msesage...

I've tested with -profile test and it produces output and no errors.

Resolves #393

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0dfad70

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-25 12:06:40

jfy133
jfy133 commented May 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
prototaxites
prototaxites reviewed May 17, 2023
View reviewed changes
bin/run_busco.sh Outdated Show resolved Hide resolved
@skrakau skrakau mentioned this pull request May 25, 2023
Merged
9 tasks
@skrakau
Copy link
Member

skrakau commented May 25, 2023

Hi, isn't the output env variable most_spec_db missing?
I made a PR since I tested it: jfy133#15

skrakau
skrakau reviewed May 25, 2023
View reviewed changes
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing output env variable, it looks good to me! One could add a proper handling of the input arguments with getopts, but not necessary in my opinion ...

@jfy133
Copy link
Member Author

jfy133 commented May 25, 2023 •
edited
Loading

Other than the missing output env variable, it looks good to me! One could add a proper handling of the input arguments with getopts, but not necessary in my opinion ...

If you felt like doing that go ahead, I was trying simply for a one-to-one conversion here as I assumed the 'script' wouldn't really b e used outside of the pipeline 😬

skrakau
skrakau approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@jfy133 jfy133 merged commit 75b3b37 into nf-core:dev May 25, 2023
@jfy133 jfy133 deleted the busco-script branch May 25, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

@d4straub d4straub Awaiting requested review from d4straub

@prototaxites prototaxites Awaiting requested review from prototaxites

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfy133 @skrakau @prototaxites