Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for release #321

Merged
merged 9 commits into from
Jun 13, 2022
Merged

Fixes for release #321

merged 9 commits into from
Jun 13, 2022

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Jun 8, 2022

Addressing review comments for release.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@skrakau skrakau requested a review from d4straub June 8, 2022 15:50
d4straub
d4straub approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau
Copy link
Member Author

skrakau commented Jun 8, 2022

there seems to be a problem with the busco links currently

jfy133
jfy133 approved these changes Jun 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
docs/output.md Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Jun 9, 2022

@nf-core-bot fix linting

@jfy133
Copy link
Member

jfy133 commented Jun 9, 2022

Oh man that' doesn't work I guess coming from a fork, 😥

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c7d9edd

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.2.0'
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-13 09:49:35

@jfy133
Copy link
Member

jfy133 commented Jun 9, 2022

Busco data website still down: https://busco-data.ezlab.org/v5/data/

@d4straub
Copy link
Collaborator

d4straub commented Jun 9, 2022

That's really bad!

@d4straub
Copy link
Collaborator

Test are successful now 👍

@skrakau skrakau merged commit c46ddd7 into nf-core:dev Jun 13, 2022
@skrakau skrakau deleted the fix_for_release branch July 22, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrakau @jfy133 @d4straub