Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing of input parameter #133

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix processing of input parameter #133

merged 3 commits into from
Nov 19, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Nov 18, 2020

Fixed issue #131: internally still the deprecated params.reads where processed instead of params.input (sorry! must have overseen something when merging the template).

To avoid future confusions and avoid the warning
"WARN: Access to undefined parameter input_paths -- Initialise it to a default value eg. params.input_paths = some_value"
for users when not running test profiles, I also initialised the input_paths variable again (even though it was removed from the template).

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

@skrakau skrakau marked this pull request as ready for review November 18, 2020 17:12
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau skrakau merged commit e26244b into nf-core:dev Nov 19, 2020
@skrakau skrakau deleted the fix_input branch May 31, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants